Skip to content

Fix mTempFiles being null when inside a tab view on Android #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mystborn
Copy link

@mystborn mystborn commented Feb 3, 2025

When a DocumentView is inside of a BottomTabNavigator from @react-navigation/bottom-tabs, it will be detached from the window without being completely destroyed. The next time the user goes to the tab, the app will crash because mTempFiles was set to null inside of onDetachedFromWindow

but onAttachedToWindow still tries to read it:

To fix, I just added a safety check to make sure the field is initialized before use inside of onAttachedToWindow.

@sgong-pdftron
Copy link
Contributor

Closing in favor of #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants