fix: use Object.setPrototypeOf in JS bindings #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CountBleck
changed the title
CountBleck
changed the title
Apparently some bundlers use objects with read-only properties for imported modules. This conflicts with Object.assign even though the object being assigned to only has read-only properties on its prototype. Regardless, if the assignment is done before the prototype is set, everything works just fine. Fixes AssemblyScript#2659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2659.
Changes proposed in this pull request:
⯈ Use
Object.setPrototypeOf({ /* instrumented imports */ }, __moduleN)instead ofObject.assign(Object.create(__moduleN), { /* instrumented imports */ })