Skip to content

Delete old field on import #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlexD717
Copy link
Member

@AlexD717 AlexD717 commented Jun 17, 2025

Description

When spawning a new game field all other game fields are removed, but robots are kept

Testing Done

  • Spawned field with no fields spawned yet
  • Spawned field with a field already spawned
  • Spawned field with a robot already spawned
  • Spawned field with a robot and field already spawned

JIRA Issue
Jira Issue 1876

AlexD717 added 2 commits June 17, 2025 11:59
Before spawning a new field, all other fields are removed
@AlexD717 AlexD717 requested review from HunterBarclay and a team as code owners June 17, 2025 19:09
@AlexD717 AlexD717 requested a review from Dhruv-0-Arora June 17, 2025 19:09
@BrandonPacewic BrandonPacewic added the gameplay Relating to the playability of Synthesis label Jun 17, 2025
@BrandonPacewic BrandonPacewic self-requested a review June 17, 2025 19:12
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrandonPacewic @PepperLola What are your thoughts on creating a confirmation panel notifying the user that it will remove all the fields

@AlexD717 AlexD717 requested a review from Dhruv-0-Arora June 17, 2025 21:18
@Dhruv-0-Arora
Copy link
Collaborator

Note: Previous commit doubles the timeout time for unit tests to 10,000 ms

@AlexD717
Copy link
Member Author

@BrandonPacewic @PepperLola What are your thoughts on creating a confirmation panel notifying the user that it will remove all the fields

Conformation panel is not feasible with the current UI implementation, we will do a UI refactor later and then implement a conformation panel (Paraphrased from Julian)

chore: ran formatter
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PepperLola PepperLola requested a review from a team as a code owner June 18, 2025 18:14
@PepperLola PepperLola self-requested a review June 18, 2025 18:14
@BrandonPacewic BrandonPacewic changed the title Alexey/1876/delete old field on import Delete old field on import Jun 18, 2025
@Dhruv-0-Arora Dhruv-0-Arora self-requested a review June 18, 2025 18:39
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Need to revert all the formatting changes that I included.

Kept the timemout change in testing
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready 👍

@PepperLola PepperLola merged commit 492e880 into Autodesk:dev Jun 18, 2025
14 of 15 checks passed
@BrandonPacewic BrandonPacewic mentioned this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Relating to the playability of Synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants