-
Notifications
You must be signed in to change notification settings - Fork 60
Delete old field on import #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete old field on import #1127
Conversation
Before spawning a new field, all other fields are removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrandonPacewic @PepperLola What are your thoughts on creating a confirmation panel notifying the user that it will remove all the fields
Co-authored-by: Dhruv Arora <[email protected]>
Note: Previous commit doubles the timeout time for unit tests to 10,000 ms |
Conformation panel is not feasible with the current UI implementation, we will do a UI refactor later and then implement a conformation panel (Paraphrased from Julian) |
chore: ran formatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Need to revert all the formatting changes that I included.
Kept the timemout change in testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready 👍
Description
When spawning a new game field all other game fields are removed, but robots are kept
Testing Done
JIRA Issue
