Skip to content

Improve Preferences Interface [AARD-1906] #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Jun 20, 2025

Description

Propagates preference changes instantly instead of waiting for the panel to close. Also replaces the type assertions in the preference system with more robust generics for type checking

AARD-1906

@rutmanz rutmanz requested review from a team as code owners June 20, 2025 16:47
@BrandonPacewic BrandonPacewic added the ui/ux Relating to user interface, or in general, user experience label Jun 20, 2025
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be something to merge after #1070 since it will cause a lot of merge conflicts if we merge it before 😓

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1135 first.

Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some persistent issues here, will take over this PR since @rutmanz is out for the week.

@BrandonPacewic BrandonPacewic self-assigned this Jun 23, 2025
@BrandonPacewic BrandonPacewic marked this pull request as draft June 23, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants