-
Notifications
You must be signed in to change notification settings - Fork 60
Improve Preferences Interface [AARD-1906]
#1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be something to merge after #1070 since it will cause a lot of merge conflicts if we merge it before 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1135 first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some persistent issues here, will take over this PR since @rutmanz is out for the week.
Description
Propagates preference changes instantly instead of waiting for the panel to close. Also replaces the type assertions in the preference system with more robust generics for type checking
AARD-1906