Skip to content

Fix overlapping spawn and configure panels #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Jun 20, 2025

Description

Closes the mirabuf import panel when the configure panel is opened. Prevents this behavior
image

AARD-1992

@rutmanz rutmanz requested review from HunterBarclay and a team as code owners June 20, 2025 23:40
@rutmanz rutmanz changed the base branch from prod to dev June 20, 2025 23:40
@rutmanz rutmanz requested a review from a team as a code owner June 20, 2025 23:40
@rutmanz rutmanz requested a review from PepperLola June 20, 2025 23:40
@rutmanz rutmanz changed the title Zachr/1992/overlapping panels Fix overlapping spawn and configure panels Jun 20, 2025
@rutmanz rutmanz added bug ui/ux Relating to user interface, or in general, user experience labels Jun 21, 2025
@rutmanz rutmanz self-assigned this Jun 21, 2025
Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue where if you are in the Assembly Setup (where you choose the input scheme) the configure panel can be opened above it.

@BrandonPacewic BrandonPacewic self-assigned this Jun 23, 2025
@BrandonPacewic
Copy link
Member

There is still an issue where if you are in the Assembly Setup (where you choose the input scheme) the configure panel can be opened above it.

@AlexD717 Can you provide a screenshot of this issue?

@AlexD717
Copy link
Member

There is still an issue where if you are in the Assembly Setup (where you choose the input scheme) the configure panel can be opened above it.

@AlexD717 Can you provide a screenshot of this issue?

Screenshot 2025-06-23 120200
The issue occurs if you press spawn asset then select any robot and then press configure assets

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon further investigation this issue is best solved by adding some sort of exclusive panel option. The fixes presented here are really just bandaid fixes.

So this should be done after the UI refactor. I'll leave this PR open for now but hopefully the UI refactor will solve these problems.

@BrandonPacewic BrandonPacewic marked this pull request as draft June 23, 2025 22:50
Copy link
Member

@AlexD717 AlexD717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another issue now where if you are in the initial-config panel and its closed due to you opening the configuration panel, the robot never fully configures which results in you not being able to control it.

@BrandonPacewic
Copy link
Member

There is another issue now where if you are in the initial-config panel and its closed due to you opening the configuration panel, the robot never fully configures which results in you not being able to control it.

Yes this is also something that I am aware of at this point. Thinking that UI refactor first and foremost is the best possible plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants