-
Notifications
You must be signed in to change notification settings - Fork 60
Fix overlapping spawn and configure panels #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still an issue where if you are in the Assembly Setup (where you choose the input scheme) the configure panel can be opened above it.
@AlexD717 Can you provide a screenshot of this issue? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon further investigation this issue is best solved by adding some sort of exclusive panel option. The fixes presented here are really just bandaid fixes.
So this should be done after the UI refactor. I'll leave this PR open for now but hopefully the UI refactor will solve these problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another issue now where if you are in the initial-config panel and its closed due to you opening the configuration panel, the robot never fully configures which results in you not being able to control it.
Yes this is also something that I am aware of at this point. Thinking that UI refactor first and foremost is the best possible plan. |
Description
Closes the mirabuf import panel when the configure panel is opened. Prevents this behavior

AARD-1992