Utility Module Unit Tests [AARD-1932]
#1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhruv-0-Arora
approved these changes
Jun 27, 2025
azaleacolburn
approved these changes
Jun 27, 2025
|
|
||
| test("Evaluates Subtraction of Width (W) and Height (H) Units Correctly", () => { | ||
| const expr = DOMUnitExpression.fromUnit(0.5, "w").sub(DOMUnitExpression.fromUnit(0.2, "h")) | ||
| // 0.5 * 400 - 0.2 * 200 = 200 - 40 = 160 |
There was a problem hiding this comment.
Very helpful comments!
ryanzhangofficial
approved these changes
Jun 27, 2025
* dev: (25 commits) Update fission/src/systems/preferences/PreferencesSystem.ts Undo vite.config.ts timout increase Removed formatting Timeout changed back Typo vite.config.ts no auto format No Auto Format on vite.config.ts Unit test timeout set to one minute format Update fission/src/ui/panels/configuring/assembly-config/ConfigurePanel.tsx Update fission/src/systems/preferences/PreferencesSystem.ts Update fission/src/ui/panels/configuring/assembly-config/ConfigurePanel.tsx Clamp Function Unit Test center download + abstraction fix: upgrade three from 0.159.0 to 0.177.0 UI download all assets Replace compress with minify Update vite.config.ts input schemes save/cancel logic ...
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for required functions in the util folder.
Testing Done
JIRA Issue