-
Notifications
You must be signed in to change notification settings - Fork 60
Exporter Reloading #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporter Reloading #1185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this is indeed more jank than I was even expecting to be honest. I'll double check that this works and make some sort of note about this in the exporter rewrite. This dose look like a good solution but it just feels... not right...
* dev: (21 commits) docs(physics): add github pr and jira issue link comment fix(mitigate): some robots now levitate closer to the ground (indistinguishable for some) fix: finish merging and formatting fix: rename PerformanceMonitoring system, run formatter doc(pr): remove code quality checkbox + whitespace removal doc(pr): update pull request template Update fission/src/systems/PerformanceMonitor.ts fix: comments and formatting feat: add performance monitoring system World.ts Unit Tests Created feat: move center of mass indicators to preference panel add tooltip + ui refactor eject individual pieces FIFO/LIFO ejection logic intake multiple gamepieces logic fix save bug Update ejector UI update intake UI add gamepiece preferences fix: make center of mass terminology consistent ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super happy about this but it certainly does appear to work. Need to double check how C++ Fusion extensions are treated. If they are compiled into some sort of shared library then referenced its possible that this issue is worse in C++ compared to Python. I have no way of knowing that till I run some tests but this will do for now.
🧇
Description
Allow for reloading the exporter code by disabling and re-enabling the exporter plugin -> instead of restarting fusion.
Testing
Make a change to one of the tabs then disable and re-run the Synthesis addin to see if your changes were loaded.
JIRA Issue