Blogging prompt: Fix Simple

[allilevine]

Fixes https://linear.app/a8c/issue/CML-493/daily-writing-prompt-broken-opens-blank-new-post

Proposed changes:

• Theory: Sometimes the editor would initialize with a default paragraph block before our code ran. This meant that waitForEditor wasn't resolving correctly because it's no longer a "clean" new post (has a block).
• This PR adds an immediate check for either a clean post or existing blocks and a safety timeout so we don't get stuck.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

See p1747465988418239-slack-C03NLNTPZ2T

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

• Create a new Simple site in an incog window.
• Apply bin/jetpack-downloader test jetpack fix/simple-blogging-prompts to your sandbox.
• Turn on write access: allow-sandbox-production-writes "10 minutes"
• Sandbox your Simple site (not the API).
• Go to /home/{site url}
• Click "Post answer" in the writing prompt home card.
• The block should show up in the editor.
• Regression test reposting a post to the site from /reader.
• Regression test that you can manually add the "Writing prompt" block.
• Repeat these tests on Jetpack and a WoA site via the Jetpack beta plugin. You can append /wp-admin/post-new.php?answer_prompt=1944 to the site URL if needed to test.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/simple-blogging-prompts branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/simple-blogging-prompts

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly:
  • Scheduled release: June 3, 2025
  • Code freeze: June 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/extensions/shared/wait-for-editor.js	0/14 (0.00%)	0.00%	3 ❤️‍🩹

Full summary · PHP report · JS report

[Addison-Stavlo]

Just noting some testing so far. When I find a simple site where this is not working, these current draft changes do seem to fix it consistently. On atomic, the feature continues to work as expected as well.

[Addison-Stavlo]

It looks reasonable and it tested well as noted.

It looks like the only other place we use waitForEditor is with the reader repost that inserts the embed block. It also seems odd that I haven't been able to reproduce any issues with that flow. It looks like the main difference is that uses resetEditorBlocks while this uses insertBlocks, in retrospect I wonder if that reset action makes more sense here and doesn't have the same issue with inconsistency? 🤔

[Addison-Stavlo]

Would it make sense to check isCleanNewPost here as well?

[allilevine]

Yes, thanks for catching that! Updated in f22d317

[allilevine]

I had to revert that change -- for some reason checking isCleanNewPost too makes it fail intermittently again. 😢 It seems like it created another race condition.

[allilevine]

It looks like the only other place we use waitForEditor is with the reader repost that inserts the embed block. It also seems odd that I haven't been able to reproduce any issues with that flow. It looks like the main difference is that uses resetEditorBlocks while this uses insertBlocks, in retrospect I wonder if that reset action makes more sense here and doesn't have the same issue with inconsistency? 🤔

@Addison-Stavlo Summing up our conversation in Slack: p1748360821224579/1747465988.418239-slack-C03NLNTPZ2T We could potentially switch to resetEditorBlocks for the blogging prompt block, but the blogging prompt shouldn't reset the editor and remove all existing blocks. Also, with the change here to check for blocks first, we could potentially be removing blocks for reposting -- but that's a very unlikely edge case. Reposts aren't added manually or with other paragraph blocks, like prompts.