Skip to content

WP.com Site Helper: add a filter to update WP Admin footer text to add a support link #43619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

lancewillett
Copy link
Contributor

@lancewillett lancewillett commented May 26, 2025

Fixes DOTSITE-23

Proposed changes:

  • Add a filter to WP Cloud sites hosted on WordPress.com to show various support links in the site's WP Admin page footer

Testing instructions:

  1. Apply patch
  2. View WP Admin footer (any page)
  3. Verify that the normal WordPress.org link is changed to the new behavior: two links, one to wordpress.com/hosting and
    the second to WordPress.com support "Help Center"

Does this pull request change what data or activity we track or use?

No.

@lancewillett lancewillett requested review from kraftbj and jeherve May 26, 2025 16:41
Copy link
Contributor

github-actions bot commented May 26, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/wp-cloud-wp-admin-footer-links branch.

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented May 26, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 26, 2025
@lancewillett lancewillett added [Status] Needs Review This PR is ready for review. [Type] Task [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Task labels May 26, 2025
@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 26, 2025
@lancewillett lancewillett added the [Status] Needs Review This PR is ready for review. label May 26, 2025
Copy link

jp-launch-control bot commented May 26, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/wpcomsh/footer-credit/footer-credit-optimizations.php 0/131 (0.00%) 0.00% 6 💔

Full summary · PHP report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label May 26, 2025
@lancewillett lancewillett changed the title Footer credits: Add a filter to update WP Admin footer links for WP.com "WP Cloud" sites WP.com Site Helper: add a filter to update WP Admin footer text to add a support link May 26, 2025
@lancewillett lancewillett added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 26, 2025
@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 26, 2025
@lancewillett lancewillett added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 26, 2025
function wpcom_wpcloud_admin_footer() {
$footer_links = array(
__( 'Thank you for creating with <a href="https://wordpress.com/hosting/">WordPress.com WordPress Hosting</a>', 'wpcomsh' ),
'<a href="https://wordpress.com/' . get_bloginfo( 'language' ) . '/support/" target="_blank">' . __( 'Help &amp; Support', 'wpcomsh' ) . '</a>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think get_bloginfo( 'language' ) will provide us with the correct link. As an example, the French support docs live at https://wordpress.com/fr/support/, not https://wordpress.com/fr-FR/support/

Maybe you can strip that second part?

On simple, however, you'll be able to use localized_wpcom_url:
183802-ghe-Automattic/wpcom#pullrequestreview-349010

In an ideal world, we'd have access to it on Atomic as well, by moving the utility to the jetpack-mu-wpcom package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch! This was already in place on Simple sites. I need to retest it there, as well.

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Wpcomsh [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants