-
Notifications
You must be signed in to change notification settings - Fork 818
WP.com Site Helper: add a filter to update WP Admin footer text to add a support link #43619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
function wpcom_wpcloud_admin_footer() { | ||
$footer_links = array( | ||
__( 'Thank you for creating with <a href="https://wordpress.com/hosting/">WordPress.com WordPress Hosting</a>', 'wpcomsh' ), | ||
'<a href="https://wordpress.com/' . get_bloginfo( 'language' ) . '/support/" target="_blank">' . __( 'Help & Support', 'wpcomsh' ) . '</a>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think get_bloginfo( 'language' )
will provide us with the correct link. As an example, the French support docs live at https://wordpress.com/fr/support/
, not https://wordpress.com/fr-FR/support/
Maybe you can strip that second part?
On simple, however, you'll be able to use localized_wpcom_url
:
183802-ghe-Automattic/wpcom#pullrequestreview-349010
In an ideal world, we'd have access to it on Atomic as well, by moving the utility to the jetpack-mu-wpcom
package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch! This was already in place on Simple sites. I need to retest it there, as well.
Fixes DOTSITE-23
Proposed changes:
Testing instructions:
the second to WordPress.com support "Help Center"
Does this pull request change what data or activity we track or use?
No.