Skip to content

CRM: Update Chart.js dependency to 4.5.0 #43990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2025
Merged

CRM: Update Chart.js dependency to 4.5.0 #43990

merged 8 commits into from
Jun 19, 2025

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Jun 17, 2025

This updates Chart.js to 4.5.0. There were no breaking changes, but some filenames changed and I cleaned up a bit of the code (e.g. moving JS content into the proper JS file).

I also adjusted the dash main chart header a bit to look better on mobile.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Create a few contacts and transactions.
  2. Verify the two charts (and the funnel) load as expected on the dash: /wp-admin/admin.php?page=zerobscrm-dash

@tbradsha tbradsha self-assigned this Jun 17, 2025
@tbradsha tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Jun 17, 2025
Copy link
Contributor

github-actions bot commented Jun 17, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/crm/chart.js branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/crm/chart.js
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/crm/chart.js

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] CRM Issues about the Jetpack CRM plugin Admin Page React-powered dashboard under the Jetpack menu labels Jun 17, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented Jun 17, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/crm/includes/ZeroBSCRM.ScriptsStyles.php 0/304 (0.00%) 0.00% -1 💚
projects/plugins/crm/admin/dashboard/main.page.php 0/223 (0.00%) 0.00% -25 💚

Full summary · PHP report · JS report

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 👍

@tbradsha tbradsha merged commit 438b8f6 into trunk Jun 19, 2025
75 checks passed
@tbradsha tbradsha deleted the update/crm/chart.js branch June 19, 2025 12:27
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] CRM Issues about the Jetpack CRM plugin [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants