Add Jetpack Monitor uptime in get site endpoint response #43999

taipeicoder · 2025-06-18T09:12:21Z

Ref DOTDASH-55.

Proposed changes:

This PR introduces the uptime field to the GET site endpoint. This field will be used to populate Jetpack Monitor uptime data for WP.com site/sites endpoints.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

This PR does not introduce any behavioral changes.

github-actions · 2025-06-18T09:13:08Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/site-endpoint-uptime-field branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/site-endpoint-uptime-field

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-06-18T09:13:17Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: July 1, 2025
- Code freeze: June 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-06-18T09:21:00Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/sal/class.json-api-site-base.php	11/307 (3.58%)	-0.01%	1 ❤️‍🩹
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-get-site-endpoint.php	468/619 (75.61%)	0.12%	0 💚

Full summary · PHP report · JS report

fushar

Tested:

✅ https://public-api.wordpress.com/rest/v1.2/me/sites -- returns the new field
❌ https://public-api.wordpress.com/rest/v1.1/sites/:idOrSlug does not return the new field. Is this expected? Or I guess it's OK since we don't need this at single-site level as we already have another endpoint for it?

How I test:

sandboxed public-api
checked out the branch 185812-ghe-Automattic/wpcom on wpcom
applied jetpack-downloader of this PR on wpcom
and used Jetpack Beta Tester of this PR on the site.

fushar · 2025-06-18T11:50:40Z

projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-get-site-v1-2-endpoint.php

@@ -82,6 +82,7 @@ class WPCOM_JSON_API_GET_Site_V1_2_Endpoint extends WPCOM_JSON_API_GET_Site_Endp
 		'is_deleted'                  => '(bool) If the site flagged as deleted.',
 		'is_a4a_client'               => '(bool) If the site is an A4A client site.',
 		'is_a4a_dev_site'             => '(bool) If the site is an A4A dev site.',
+		'uptime'                      => '(array) An array keyed by unit of time that contains the site uptime for each day.',


Follow-up: Is it really needed here?

Looking closer, it inherits from the base class so it's not needed.

taipeicoder · 2025-06-18T14:45:27Z

projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-get-site-endpoint.php

@@ -240,6 +241,7 @@ class WPCOM_JSON_API_GET_Site_Endpoint extends WPCOM_JSON_API_Endpoint {
 		'was_hosting_trial',
 		'was_upgraded_from_trial',
 		'is_a4a_dev_site',
+		'uptime',


This is needed so that when the a request is made on WoA sites, the endpoint redecorates the response with these WPCOM values.

taipeicoder · 2025-06-19T09:40:34Z

Closing as we're not pursuing this approach for now.

Add Jetpack Monitor uptime in get site endpoint response

d113439

taipeicoder self-assigned this Jun 18, 2025

github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jun 18, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 18, 2025

taipeicoder added [Type] Task [Status] Needs Review This PR is ready for review. labels Jun 18, 2025

Add to site-v1-2-endpoint as well

da78cfe

taipeicoder requested a review from a team June 18, 2025 09:43

Return null instead of empty array

4870e7c

fushar reviewed Jun 18, 2025

View reviewed changes

taipeicoder mentioned this pull request Jun 18, 2025

Sites List v2: Implement Uptime column Automattic/wp-calypso#104297

Merged

9 tasks

fushar reviewed Jun 18, 2025

View reviewed changes

Ensure uptime is returned for the site endpoint

3df10e3

taipeicoder commented Jun 18, 2025

View reviewed changes

taipeicoder closed this Jun 19, 2025

github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. labels Jun 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Jetpack Monitor uptime in get site endpoint response #43999

Add Jetpack Monitor uptime in get site endpoint response #43999

Uh oh!

taipeicoder commented Jun 18, 2025

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Jun 18, 2025 •

edited

Loading

Uh oh!

fushar left a comment

Uh oh!

fushar Jun 18, 2025

Uh oh!

taipeicoder Jun 18, 2025

Uh oh!

taipeicoder Jun 18, 2025

Uh oh!

taipeicoder commented Jun 19, 2025

Uh oh!

Uh oh!

Add Jetpack Monitor uptime in get site endpoint response #43999

Add Jetpack Monitor uptime in get site endpoint response #43999

Uh oh!

Conversation

taipeicoder commented Jun 18, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

fushar left a comment

Choose a reason for hiding this comment

Uh oh!

fushar Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

taipeicoder Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

taipeicoder Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

taipeicoder commented Jun 19, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited

Loading

github-actions bot commented Jun 18, 2025 •

edited

Loading

jp-launch-control bot commented Jun 18, 2025 •

edited

Loading