Skip to content

fix(query): handle $round in $expr as array #13928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix(query): handle $round in $expr as array #13928

merged 2 commits into from
Oct 4, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13881

Summary

$round syntax takes an array, not a number. This PR fixes that.

Examples

hasezoey
hasezoey requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, though from what i read <place>(second array element) is optional, where this change makes it seem to be required

IslandRhythms
IslandRhythms approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkarpov15 vkarpov15 added this to the 7.5.4 milestone Oct 4, 2023
@vkarpov15 vkarpov15 merged commit a57bb72 into master Oct 4, 2023
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13881 branch October 4, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey requested changes

@IslandRhythms IslandRhythms IslandRhythms approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.5.4
Development

Successfully merging this pull request may close these issues.

Cannot use $round in find with $expr
3 participants
@vkarpov15 @hasezoey @IslandRhythms