Skip to content

User Option: Limit to users with Activitypub cap #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Conversation

obenland
Copy link
Member

@obenland obenland commented Jun 2, 2025

See #1747 (review)

Proposed changes:

  • Changes user query from authors to anyone with the activitypub capability.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to the Editor and insert a Follow Me or Followers block.
  • In the sidebar, make sure that all users with the activitypub capability are listed, even if they have the Subscriber role.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Follow Me and Followers blocks can now list any user that is Activitypub-enabled, even if they have the Subscriber role.

@obenland obenland requested review from pfefferle and Copilot June 2, 2025 17:58
@obenland obenland self-assigned this Jun 2, 2025
@github-actions github-actions bot added the [Focus] Editor Changes to the ActivityPub experience in the block editor label Jun 2, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the user query used in several blocks to filter for ActivityPub‐enabled users rather than just authors. Key changes include updating the query in use-user-options.js, adding a default parent value in the reactions render, and ensuring that dynamic user queries in the Followers and Follow Me blocks use the ActivityPub capability filter.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
src/shared/use-user-options.js Updated query to use capabilities:"activitypub" and added documentation.
build/reactions/render.php Added a default "parent" key with value 0.
build/followers/index.js Adjusted the Followers block to use ActivityPub capability filtering.
build/follow-me/index.js Updated the Follow Me block to ensure consistency in querying users.

@obenland obenland mentioned this pull request Jun 2, 2025
11 tasks
@obenland obenland requested a review from pfefferle June 3, 2025 15:16
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@obenland obenland merged commit bd17d13 into trunk Jun 3, 2025
11 checks passed
@obenland obenland deleted the fix/user-selector branch June 3, 2025 16:22
@obenland obenland mentioned this pull request Jun 9, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Editor Changes to the ActivityPub experience in the block editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants