Skip to content

Editor Script: Add back compat with WP 6.5 #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2025
Merged

Conversation

obenland
Copy link
Member

@obenland obenland commented Jun 3, 2025

Testing the new blocks in WordPress 6.5 I noticed errors for the EditorPlugin in the Editor. It looks like the Core-bundled version of the @wordpress/editor package in WP 6.5 doesn't yet contain the PluginDocumentSettingPanel component.
I added a dependency on @wordpress/edit-post, which is where it lived back then, as a fallback.

Proposed changes:

  • Adds @wordpress/edit-post to npm dev dependencies.
  • Adds fallback for PluginDocumentSettingPanel in WP 6.5.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • On WordPress 6.5, open the Block Editor and make sure there is no red banner with an error notice at the top of the screen.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Fixes a bug in WordPress 6.5 where the plugin settings in the Editor would fail to render, due to a backwards compatibility break.

@obenland obenland self-assigned this Jun 3, 2025
@github-actions github-actions bot added [Block] Post settings [Focus] Editor Changes to the ActivityPub experience in the block editor [Status] In Progress labels Jun 3, 2025
@obenland obenland requested a review from pfefferle June 3, 2025 19:48
@obenland obenland marked this pull request as ready for review June 3, 2025 19:48
pfefferle
pfefferle previously approved these changes Jun 4, 2025
@obenland obenland merged commit c3c0897 into trunk Jun 4, 2025
12 checks passed
@obenland obenland deleted the fix/editor-script branch June 4, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post settings [Focus] Editor Changes to the ActivityPub experience in the block editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants