Skip to content

Subscribers: fix time since #103787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025
Merged

Subscribers: fix time since #103787

merged 5 commits into from
Jun 2, 2025

Conversation

arcangelini
Copy link
Contributor

@arcangelini arcangelini commented May 28, 2025

Proposed Changes

Switch from Since subscribed to Date Subscribed in subscribers data view.

Screen Shot 2025-05-29 at 16 43 29

Why are these changes being made?

Currently the time difference from subscribed is checking against UTC time rather than the sites time. Adding the +00:00 to the subscribed date fixes that part.

I also don't think it is necessary to show "time since" in this area. There doesn't appear to be a reason that someone would need this detail over just the subscribed date. Moving this to just a simple date simplifies things I believe.

Testing Instructions

  1. Pull the branch and navigate to /subscribers/YOUR_SITE.com
  2. Check that the Date Subscribed column is showing the correct dates in the correct order.
  3. Add a new subscriber and verify the order is still correct.
  4. Change timezone on your site and make sure the order is still correct.
  5. Change languages for your user and ensure it shows the proper date.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented May 28, 2025

@matticbot
Copy link
Contributor

matticbot commented May 28, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~68 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
subscribers       +114 B  (+0.0%)      +68 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented May 29, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/issue-cml-530 on your sandbox.

@arcangelini arcangelini requested a review from a team May 29, 2025 20:52
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 29, 2025
@arcangelini arcangelini self-assigned this May 29, 2025
@arcangelini arcangelini added the Subscribers Page The new Subscribers page in Calypso label May 29, 2025
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well on my end. I just left some minor notes on the new translation.

render: ( { item }: { item: Subscriber } ) => (
<TimeSince date={ getSubscriptionDate( item ) } />
),
label: translate( 'Date Subscribed' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think technically we do all labels in sentence case now, although this is currently all caps in the interface here anyways. It may be good to move it to sentence case for consistency if the typography styles were changed.

It also doesn't look like we have existing translations for "Date Subscribed". So we could use the fixMe function from the i18n-calypso library to provide this new translation with the old translation as a fallback while the new one is being translated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call! Thanks @Addison-Stavlo

arcangelini and others added 2 commits June 2, 2025 11:26
Update the date_subscribed field label to use fixMe() to handle the copy change from 'Since' to 'Date subscribed'. Also added locale to the useMemo dependency array.
@arcangelini arcangelini merged commit 3c9901c into trunk Jun 2, 2025
11 checks passed
@arcangelini arcangelini deleted the fix/issue-cml-530 branch June 2, 2025 20:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 2, 2025
@a8ci18n
Copy link

a8ci18n commented Jun 2, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17535013

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @arcangelini for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subscribers Page The new Subscribers page in Calypso
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants