-
Notifications
You must be signed in to change notification settings - Fork 2k
Subscribers: fix time since #103787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribers: fix time since #103787
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~68 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well on my end. I just left some minor notes on the new translation.
render: ( { item }: { item: Subscriber } ) => ( | ||
<TimeSince date={ getSubscriptionDate( item ) } /> | ||
), | ||
label: translate( 'Date Subscribed' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think technically we do all labels in sentence case now, although this is currently all caps in the interface here anyways. It may be good to move it to sentence case for consistency if the typography styles were changed.
It also doesn't look like we have existing translations for "Date Subscribed". So we could use the fixMe
function from the i18n-calypso
library to provide this new translation with the old translation as a fallback while the new one is being translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great call! Thanks @Addison-Stavlo
Update the date_subscribed field label to use fixMe() to handle the copy change from 'Since' to 'Date subscribed'. Also added locale to the useMemo dependency array.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17535013 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @arcangelini for including a screenshot in the description! This is really helpful for our translators. |
Proposed Changes
Switch from
Since
subscribed toDate Subscribed
in subscribers data view.Why are these changes being made?
Currently the time difference from subscribed is checking against UTC time rather than the sites time. Adding the
+00:00
to the subscribed date fixes that part.I also don't think it is necessary to show "time since" in this area. There doesn't appear to be a reason that someone would need this detail over just the subscribed date. Moving this to just a simple date simplifies things I believe.
Testing Instructions
/subscribers/YOUR_SITE.com
Pre-merge Checklist