Skip to content

Purchase Management: Add pagination and search to purchases DataViews #103788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 29, 2025

Conversation

sirbrillig
Copy link
Member

@sirbrillig sirbrillig commented May 28, 2025

Proposed Changes

This PR adds support for pagination and search to the DataViews version of the purchases list.

Note

This version of the purchases list is still behind a feature flag. To test this you will need to manually enable the purchases/purchase-list-dataview flag in your local development.json config before starting calypso.

Part of https://linear.app/a8c/project/replace-calypsos-active-upgrades-subscriptions-with-dataviews-a7b39dea5417/overview / #86616
Tracked by https://linear.app/a8c/issue/CHE-152/implement-pagination-on-dataviews-subscription-list

Screenshots

Screenshot 2025-05-28 at 5 51 01 PM Screenshot 2025-05-28 at 5 51 14 PM

Testing Instructions

  • Use an account which has a number of purchases, the more the better.
  • Visit /me/purchases with the DataView enabled (see above).
  • Verify that entering text into the search field for the purchases list (and the memberships list, if you have any) filters the list by that text. You can use the product name and type (eg "Plan"), the site name, the site domain, and the site primary domain (if different).
  • Verify that using the pagination controls (next, previous, and the page selector) works as expected.

Copy link

github-actions bot commented May 28, 2025

@sirbrillig sirbrillig self-assigned this May 28, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug add-pagination-to-purchases-dataviews on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~662 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
purchases      +2080 B  (+0.1%)     +662 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig merged commit 629523d into trunk May 29, 2025
14 checks passed
@sirbrillig sirbrillig deleted the add-pagination-to-purchases-dataviews branch May 29, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants