Skip to content

Accessibility: Update disabled text color from Gray 10 to Gray 50 for better contrast in checkout #103814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented May 29, 2025

Resolves DOTCOM-13280

Proposed Changes

  • update disabled text color from Gray 10 to Gray 50
Before After
Markup on 2025-05-29 at 18:28:25 Markup on 2025-05-29 at 18:26:50

Note

I have tried a bit lighter shade of gray than 50, but it already triggered the contrast error

Why are these changes being made?

  • a55edfa4e3bf-linear-project

Testing Instructions

  • Check out the PR brach and build it with yarn start (or use Calypso Live).
  • Add any product to your cart and head over to the checkout page.
  • Click on the "Edit" button by your contact details.
  • Look at the "Pick a payment method" heading below. It should be in darker gray color.
  • If you install the axe DevTools extension (https://chromewebstore.google.com/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd) and scan the checkout page, the following contrast issue shoulln't be there anymore:

Markup on 2025-05-29 at 18:23:21

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this May 29, 2025
@ivan-ottinger ivan-ottinger requested a review from a team as a code owner May 29, 2025 16:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 29, 2025
Copy link

github-actions bot commented May 29, 2025

@matticbot
Copy link
Contributor

matticbot commented May 29, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/checkout-page-pick-a-payment-method-heading-contrast on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is fixed - the contrast matches the recommended level now.

@katinthehatsite
Copy link
Contributor

The contrast looks good to me and I do not see the error anymore on my end:

Screenshot 2025-06-02 at 5 57 18 AM

@ivan-ottinger ivan-ottinger force-pushed the fix/checkout-page-pick-a-payment-method-heading-contrast branch from f39acca to f1d565b Compare June 2, 2025 08:17
@ivan-ottinger
Copy link
Contributor Author

Thank you for your reviews, Wojtek & Kat.

@ivan-ottinger ivan-ottinger merged commit 4476466 into trunk Jun 2, 2025
14 checks passed
@ivan-ottinger ivan-ottinger deleted the fix/checkout-page-pick-a-payment-method-heading-contrast branch June 2, 2025 08:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants