Skip to content

Add/change supporters title #103816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: trunk
Choose a base branch
from
Open

Add/change supporters title #103816

wants to merge 10 commits into from

Conversation

millerf
Copy link
Contributor

@millerf millerf commented May 29, 2025

Part of https://linear.app/a8c/issue/SHILL-713/memberships-fix-list-of-supporters

Proposed Changes

  • Change "Supporters" to "Active Paid Subscriptions" title in MOnetize
  • Translate untranslated texts
  • Changed copy when no paid-subscriptions are available on the site
  • Rename components to reduce confusion for other devs

Why are these changes being made?

  • See issue

Testing Instructions

  • yarn start
  • Make sure you are sandboxing the store and switch to this user or go to a site with paid-subscribers
  • Open 2 tabs, one with the production (wordpress.com and the calypso:3000 with those links
  • Notice:
    • The design hasn't changed
    • Title was changed from Supporters to Active Paid Subscriptions
    • URL was updated
Screenshot 2025-05-30 at 14 38 55
  • Click on the "..." > "View details"
  • Make sure everything looks fine and notice the URL change
Screenshot 2025-05-30 at 15 31 47
  • Go to earn/paid-subscriptions/refunddomaintest5.wordpress.com and notice the change in copy.
Screenshot 2025-05-30 at 15 35 02

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented May 29, 2025

@matticbot
Copy link
Contributor

matticbot commented May 29, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~62 bytes removed 📉 [gzipped])

name  parsed_size           gzip_size
earn       +743 B  (+0.1%)      -62 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@millerf millerf force-pushed the add/change-supporters-title branch from 3c8ae91 to 50de12f Compare May 30, 2025 13:09
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/change-supporters-title on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants