Skip to content

Connect Refresh: Migrate Crowdsignal to unified Login #103830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025

Conversation

chriskmnds
Copy link
Contributor

@chriskmnds chriskmnds commented May 30, 2025

Fixes https://linear.app/a8c/issue/DOTCOM-13381/crowdsignal
Fixes https://linear.app/a8c/issue/DOTCOM-13395/crowdsignal

Proposed Changes

Updates Crowdsignal Login to match the unified designs. Updated:

  • Top bar
  • Bottom bar (removed)
  • Logo
  • Heading
  • Switched to two-column/white layout

A few notable changes that may need confirmation:

  • The original did not include Continue with GitHub and Continue with Apple CTAs. These are now added to the form.
  • The logo I pulled from the wpcom repo (.../wp-content/themes/a8c/crowd-signal/assets/images/logo-dots.svg), which is different from what's used in current Login screen.

Media

Before After
Screenshot 2025-05-30 at 12 23 50 PM Screenshot 2025-05-30 at 7 59 23 PM

Why are these changes being made?

Part of https://linear.app/a8c/issue/DOTCOM-13381/crowdsignal
Part of https://linear.app/a8c/issue/DOTCOM-13395/crowdsignal

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chriskmnds chriskmnds requested a review from a team May 30, 2025 09:50
@chriskmnds chriskmnds self-assigned this May 30, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 30, 2025
Copy link

github-actions bot commented May 30, 2025

@matticbot
Copy link
Contributor

matticbot commented May 30, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~872 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-login                -2523 B  (-0.1%)     -872 B  (-0.1%)
entry-reauth-required        +16 B  (+0.0%)      +12 B  (+0.0%)
entry-main                   +16 B  (+0.0%)      +12 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~43 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       -217 B  (-0.0%)      -43 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~43 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       -217 B  (-0.0%)      -43 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented May 30, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/connect-refresh-login-crowdsignal on your sandbox.

Base automatically changed from udpate/connect-refresh-login-akismet to trunk June 3, 2025 08:46
@chriskmnds chriskmnds force-pushed the update/connect-refresh-login-crowdsignal branch from bd4d062 to fe1de01 Compare June 3, 2025 08:47
@chriskmnds chriskmnds merged commit d9ef37e into trunk Jun 3, 2025
12 checks passed
@chriskmnds chriskmnds deleted the update/connect-refresh-login-crowdsignal branch June 3, 2025 09:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants