-
Notifications
You must be signed in to change notification settings - Fork 2k
Connect Refresh: Migrate Crowdsignal to unified Login #103830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~872 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~43 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~43 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
bd4d062
to
fe1de01
Compare
Fixes https://linear.app/a8c/issue/DOTCOM-13381/crowdsignal
Fixes https://linear.app/a8c/issue/DOTCOM-13395/crowdsignal
Proposed Changes
Updates Crowdsignal Login to match the unified designs. Updated:
A few notable changes that may need confirmation:
Continue with GitHub
andContinue with Apple
CTAs. These are now added to the form..../wp-content/themes/a8c/crowd-signal/assets/images/logo-dots.svg
),which is different from what's used in current Login screen.Media
Why are these changes being made?
Part of https://linear.app/a8c/issue/DOTCOM-13381/crowdsignal
Part of https://linear.app/a8c/issue/DOTCOM-13395/crowdsignal
Testing Instructions
Pre-merge Checklist