Skip to content

Dashboard v2: Update Notice's in defensive mode settings #103872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Jun 2, 2025

Proposed Changes

This PR updates the <Notice /> components from #103727 to use the newly designed <Notice /> from client/dashboard instead.

Disabled Enabled Enabled by a11n
image image image

Testing Instructions

Follow #103727.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Jun 2, 2025

@fushar fushar marked this pull request as ready for review June 2, 2025 04:48
@fushar fushar requested review from youknowriad and a team as code owners June 2, 2025 04:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 2, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~558 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom      +2241 B  (+0.1%)     +558 B  (+0.1%)
entry-dashboard-a4a         +2241 B  (+0.1%)     +558 B  (+0.1%)
entry-subscriptions           -50 B  (-0.0%)      -44 B  (-0.0%)
entry-stepper                 -50 B  (-0.0%)      -44 B  (-0.0%)
entry-reauth-required         -50 B  (-0.0%)      -44 B  (-0.0%)
entry-main                    -50 B  (-0.0%)      -44 B  (-0.0%)
entry-login                   -50 B  (-0.0%)      -44 B  (-0.0%)
entry-domains-landing         -50 B  (-0.0%)      -44 B  (-0.0%)
entry-browsehappy             -50 B  (-0.0%)      -44 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~644 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-settings      +2345 B  (+0.1%)     +622 B  (+0.1%)
hosting            +2345 B  (+0.1%)     +624 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fushar fushar merged commit 992fad0 into trunk Jun 2, 2025
14 checks passed
@fushar fushar deleted the defensive-mode-notice branch June 2, 2025 05:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants