Add support for pagination in FHIR accessor #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-msft
reviewed
May 28, 2025
| url = base_url | ||
| while url and len(entries) < result_count_limit: | ||
| print(f"Fetching from URL: {url}") | ||
| response = requests.get(url, headers=await self.get_headers()) |
There was a problem hiding this comment.
Consider using aiohttp here
| token = extract_continuation_token(response_json) | ||
| if token: | ||
| # Append or replace query string with continuation token | ||
| parsed_url = urllib.parse.urlparse(base_url) |
There was a problem hiding this comment.
This line can be done outside of the loop. base_url doesn't change.
| if token: | ||
| # Append or replace query string with continuation token | ||
| parsed_url = urllib.parse.urlparse(base_url) | ||
| url = f"{parsed_url.scheme}://{parsed_url.netloc}{parsed_url.path}?{token}" |
There was a problem hiding this comment.
Consider building the base url outside of the loop. URL scheme, domain and path should not change once inside the loop.
frank-msft
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for paginating results from the AHDS FHIR rest API