Skip to content

Update resource API versions and clean up formatting in Bicep files #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mbilalamjad
Copy link
Contributor

No description provided.

@segraef
Copy link

segraef commented Feb 26, 2025

Remember the provider upgrade implies a breaking change on some of the properties of the aiHub, I have a working version here if you want to have a look.

resource aiHub 'Microsoft.MachineLearningServices/workspaces@2024-10-01' = {
  name: 'aihub-${baseName}'
  location: location
  kind: 'Hub'
  sku: {
    name: 'Basic'
    tier: 'Basic'
  }
  identity: {
    type: 'SystemAssigned' // This resource's identity is automatically assigned privilege access to ACR, Storage, Key Vault, and Application Insights.
    // Since the privileges are granted at the project/hub level have elevated access to the resources, it is recommended to isolate these resources
    // to a resource group that only contains the project/hub and relevant resources.
  }
  properties: {
    friendlyName: 'Azure OpenAI Chat Hub'
    description: 'Hub to support the Microsoft Learn Azure OpenAI baseline chat implementation. https://learn.microsoft.com/azure/architecture/ai-ml/architecture/baseline-openai-e2e-chat'
    publicNetworkAccess: 'Disabled'
    allowPublicAccessWhenBehindVnet: false
    managedNetwork: {
      firewallSku: 'Standard'
      isolationMode: 'AllowOnlyApprovedOutbound'
      status: {
        status: 'Active'
        sparkReady: false
      }
      outboundRules: {
        // Default 'Required' Rules to ARM, ACR, KV, Storage, Machine Learning, Node Batch, and Cognitive Services will be created automatically
      }
    }
    v1LegacyMode: false
    workspaceHubConfig: {
      defaultWorkspaceResourceGroup: resourceGroup().id // Setting this to the same resource group as the workspace
    }

    // Default settings for projects
    storageAccount: aiStudioStorageAccount.id
    containerRegistry: containerRegistry.id
    enableDataIsolation: true
    keyVault: keyVault.id
    hbiWorkspace: false
    applicationInsights: applicationInsights.id
    discoveryUrl: 'https://${location}.api.azureml.ms/discovery'
  }

@ckittel
Copy link
Member

ckittel commented Feb 26, 2025

Can we please make these changes in the Basic version first? We want all things to trickle from there. Since this story "builds on itself" starting at "basic" and going through landing zones.

https://github.com/Azure-Samples/openai-end-to-end-basic/

I've applied the desired syntax linting changes already as an example to the basic and then rolled them forward to the baseline here, and to the landing zone version.

You'll need to rebase your PR here to pick them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants