Deprecate UseEmbeddedWebView property in BrowserCustomizationOptions #50516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion message Co-authored-by: christothes <[email protected]>
Copilot
AI
changed the title
UseEmbeddedView property on InteractiveBrowserCredentialOptions
Copilot finished work on behalf of
christothes
June 10, 2025 15:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
UseEmbeddedWebViewproperty in theBrowserCustomizationOptionsclass by adding the[Obsolete]attribute with an appropriate deprecation message.Changes Made
[Obsolete]attribute to theUseEmbeddedWebViewproperty with the message: "This option requires additional dependencies on Microsoft.Identity.Client.Desktop and is no longer supported. Consider using brokered authentication instead"#pragma warning disable CS0618suppressions in:MsalPublicClient.csthat still needs to support the property for backward compatibilityBackground
The embedded browser functionality depends on Windows Forms, which requires the Microsoft.Identity.Client.Desktop assembly. Azure.Identity does not support the
WithWindowsEmbeddedBrowserSupportscenario offered by MSAL directly, so users would need to use MSAL directly to utilize this feature. To address this limitation, we are deprecating this property and recommending users consider brokered authentication instead.Backward Compatibility
The property remains functional for existing code but will now emit compiler warnings encouraging migration to alternative authentication methods. All existing tests continue to pass with appropriate warning suppressions.
Fixes #50495.