Fixing build break in using client_certificate credentials #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msabansal I'm not sure exactly what this fix does. Can you please include a detailed description of the bug being fixed? |
bmc-msft
reviewed
Aug 17, 2022
| @@ -130,16 +135,17 @@ struct AadTokenResponse { | |||
| access_token: String, | |||
| } | |||
|
|
|||
| fn get_encoded_cert(cert: &X509) -> Result<String, ClientCertificateCredentialError> { | |||
| fn get_encoded_cert(cert: &X509) -> Result<String, azure_core::error::Error> { | |||
There was a problem hiding this comment.
Suggested change
| fn get_encoded_cert(cert: &X509) -> Result<String, azure_core::error::Error> { | |
| fn get_encoded_cert(cert: &X509) -> azure_core::Result<String> { |
|
@rylev Added the description. I am not sure why the build is passing. If someone can point me to how i can fix the test for this i am happy to do that |
rylev
approved these changes
Aug 18, 2022
| @@ -174,7 +180,7 @@ impl TokenCredential for ClientCertificateCredential { | |||
| let chain = chain | |||
| .into_iter() | |||
| .map(|x| get_encoded_cert(&x)) | |||
| .collect::<Result<Vec<String>, ClientCertificateCredentialError>>()? | |||
| .collect::<Result<Vec<String>, azure_core::error::Error>>()? | |||
There was a problem hiding this comment.
Suggested change
| .collect::<Result<Vec<String>, azure_core::error::Error>>()? | |
| .collect::<azure_core::Result<Vec<String>>>()? |
Comment on lines
+145
to
+147
| fn openssl_error() -> azure_core::error::Error { | ||
| Error::message(ErrorKind::Credential, "Openssl decode error") | ||
| } |
There was a problem hiding this comment.
I don't think we want to use the same error message for all of these errors. It makes it hard to tell what actually went wrong.
cataggar
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The identity SDK doesn't build anymore when trying to build with feature client_certificate. This PR addresses the issue.
Also added a full build on the SDK