Skip to content

Make content_location optional #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Aug 17, 2022

Fixes #1022

This is likely not the only header that is not guaranteed to be there. We should make all headers that are not part of the common response headers list optional.

@ayngling
Copy link

We are using this SDK in production (yes, we know it is unofficial, but Rust is awesome ;) ) for many customers (hundred of thousands of users in total), and was affected by the cosmos update. Microsoft helped us by rolling back our cosmos accounts to get it working again, and hence issue #1022 was created.

The long term solution is migrating to a future version of the SDK where this is not an issue, and then upgrade the accounts again. we would appreciate very much if this commit could be merged quickly!

PS: If you arrive at this issue because you are having the same issue with an error about the "content-location" header, the temporary fix is asking Azure support to roll back your cosmos account from the "Compute Gateway for SQL API" to the "legacy gateway for SQL API".

@cataggar
Copy link
Member

Hi @ayngling, thank you for this info. Are you able to use a main commit or do you need a published crate?

@cataggar cataggar merged commit f55682a into Azure:main Aug 17, 2022
@ayngling
Copy link

I would love a published crate, but in a pinch I can use a commit :)

@ayngling
Copy link

@cataggar Actually, if it is possible, a published crate would be much appreciated!

@rylev rylev deleted the content-location-optional branch August 18, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not fail for missing content-location header for CosmosDB APIs
3 participants