Skip to content

Improve message from error in retry policy that is no longer retried #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Aug 19, 2022

There are two changes in this PR:

  • Previously, the retry policy was wrapping all non-200 responses in an error with the message "server returned error status which will not be retried: {status}" even the ones that are retired. This change now only uses that message for errors that are definitely retried.
  • Additional context is now added to the error messages that were retried but no longer are because the retry limit was reached.

@rylev rylev requested a review from bmc-msft August 19, 2022 14:01
Copy link
Contributor

@gorzell gorzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@bmc-msft bmc-msft merged commit ae41a17 into Azure:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants