Redact the authorization header from Debug impl #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpad-m
requested review from
heaths,
RickWinter and
JeffreyRichter
as code owners
|
@microsoft-github-policy-service agree company="Neon, Inc." |
arpad-m
changed the title
|
Thanks. This is a good temp workaround for this problem. I've opened an issue to track a larger effort and whether we should even do that for |
heaths
approved these changes
Jul 17, 2024
auto-merge was automatically disabled
July 18, 2024 13:46
Head branch was pushed to by a user without write access
arpad-m
force-pushed
the
remove_request_logging
branch
from
b1cf219 to
c3f78ee
Compare
|
Rebased due to CI failure on nightly: https://github.com/Azure/azure-sdk-for-rust/actions/runs/9875575736/job/27588762903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if you use the azure SDK and enable debug logging, the authorization header is printed in the debug logs through this place. Printing the authorization token is dangerous however as it might get into the logging infrastructure, and become available to people with read access to the logs.
Therefore, this commit adjusts the
Debugimpl of theHeadersstruct to not print the content of the authorization header.