Skip to content

Added as_headers trait to ItemOptions #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

gsa9989
Copy link
Contributor

@gsa9989 gsa9989 commented Jun 30, 2025

Added as_headers trait to ItemOptions to send all item options headers from one function. Added tests to make sure as_headers is creating the correct type of headers. I also added the remaining item options and the necessary headers to make the correct requests. As_headers function is now used in create_item, replace_item, upsert_item, read_item, delete_item, and patch_item.

gsa9989 and others added 11 commits June 3, 2025 11:42
  ItemOptions-changes 41f2acf if_match_etag changes with tests
* main                b1d2f9f [origin/main] Merge pull request #1 from gsa9989/read-me-change
  read-me-change      653b308 read me change Please enter a commit message to explain why this merge is necessary,
  ItemOption-changes 41f2acf if_match_etag changes with tests
* main                b1d2f9f [origin/main] Merge pull request #1 from gsa9989/read-me-change
  read-me-change      653b308 merge upstream/main
…ter a commit message to explain why this merge is necessary,
@github-actions github-actions bot added the Cosmos The azure_cosmos crate label Jun 30, 2025
Copy link
Member

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes needed!

Copy link

github-actions bot commented Jul 1, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

azure_data_cosmos

@gsa9989 gsa9989 marked this pull request as ready for review July 2, 2025 18:25
Copy link
Member

@tvaron3 tvaron3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmos The azure_cosmos crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants