-
Notifications
You must be signed in to change notification settings - Fork 292
Added as_headers trait to ItemOptions #2744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gsa9989
wants to merge
17
commits into
main
Choose a base branch
from
gaby/consistency-level
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read me change
ItemOptions-changes 41f2acf if_match_etag changes with tests * main b1d2f9f [origin/main] Merge pull request #1 from gsa9989/read-me-change read-me-change 653b308 read me change Please enter a commit message to explain why this merge is necessary, ItemOption-changes 41f2acf if_match_etag changes with tests * main b1d2f9f [origin/main] Merge pull request #1 from gsa9989/read-me-change read-me-change 653b308 merge upstream/main
…ter a commit message to explain why this merge is necessary,
…to gaby/consistency-level
analogrelay
requested changes
Jul 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes needed!
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
tvaron3
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added as_headers trait to ItemOptions to send all item options headers from one function. Added tests to make sure as_headers is creating the correct type of headers. I also added the remaining item options and the necessary headers to make the correct requests. As_headers function is now used in create_item, replace_item, upsert_item, read_item, delete_item, and patch_item.