ToTokens refactor #754
Merged
ToTokens refactor #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- value instead of &value.to_string()) when Vec<String> - Vec<String> instead of impl Into<Vec<String>> in a few functions
rylev
approved these changes
May 19, 2022
| @@ -1,3 +1,4 @@ | |||
| #![allow(dead_code)] | |||
| } | ||
| } | ||
|
|
||
| enum TypeCode { |
There was a problem hiding this comment.
For all these "code" types, I'd really appreciate a doc comment that points out what they are:
/// A struct field
///
/// ```rust
/// struct My Struct {
/// my_field: u32 // <-- refers to this
/// }
/// ```
struct FieldCode {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a good milestone for the
ToTokensrefactor. Several new types are created that implement quote::ToTokens. This assists in testing the transform from OpenAPI types. Any types that implementToTokenscan be used directing inquote!macro. This makes it possible to incrementally refactor out the types.