limit tags to 5 #761
limit tags to 5 #761
Conversation
needed when an autorust.toml exists to disable the crate
|
This is a rather positive improvement from the current |
|
There are a handful of the autorust.toml files that exclude versions without explaining why, in one such example purview now excludes a tag that as far as I can tell isn't excluded in main. These should all have comments as to why limits are included. |
|
Do you have any thoughts on expanding on your autorust.toml work to include the other components currently defined in source, such as the workarounds for |
I agree. It is only a few of them. This filter is useful for reviewing:
|
| @@ -0,0 +1,12 @@ | |||
| [tags] | |||
| # manually selected from | |||
There was a problem hiding this comment.
We will need to consider how we monitor for new versions moving forward for crates where the tags are manually selected (rather than manually excluded).
Yes, I was thinking we could migrate them directly over doing something like this: [properties]
box = [
["../../../azure-rest-api-specs/specification/databox/resource-manager/Microsoft.DataBox/stable/2022-03-01/databox.json", "transferAllDetails", "include"]
]
fix_case =
invalid_type = |
|
A run of Check All Features for Services passed last night. An earlier run, showed these four failing: azure_mgmt_databoxedge I suspect, Basic explanations have been added where requested in the autorust.toml files. They can be refined in future pull requests. This should be good to merge. I started another run for the latest commit here. |
| @@ -6,70 +6,12 @@ https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containers | |||
|
|
|||
| To get started with these generated service crates, see the [examples](https://github.com/Azure/azure-sdk-for-rust/blob/main/services/README.md#examples). | |||
|
|
|||
| The default tag is `package-2022-03`. | |||
There was a problem hiding this comment.
There will probably be a few places where sorting alphabetically doesn't work. This is one. I don't think we need to fix every case in this PR though.
| @@ -6,21 +6,12 @@ https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cost-manag | |||
|
|
|||
| To get started with these generated service crates, see the [examples](https://github.com/Azure/azure-sdk-for-rust/blob/main/services/README.md#examples). | |||
|
|
|||
| The default tag is `package-2021-10`. | |||
There was a problem hiding this comment.
This is another case where sorting does not work.
| "package-preview-2021-11" = [] | ||
| "package-2021-10" = [] |
There was a problem hiding this comment.
This should probably be the default. It is the most recent stable. It may be useful to have a limit_preview = 2 option so that there are stable tags.
|
|
||
| [features] | ||
| default = ["package-2022-02", "enable_reqwest"] |
There was a problem hiding this comment.
Will probably need deny_contains = ["schema"] here.
| @@ -25,15 +25,15 @@ tokio = { version = "1.0", features = ["macros"] } | |||
| env_logger = "0.9" | |||
|
|
|||
| [package.metadata.docs.rs] | |||
| features = ["no-default-tag", "package-commitmentPlans-2016-05-preview", "package-workspaces-2016-04", "package-workspaces-2019-10", "package-webservices-2016-05-preview"] | |||
| all-features = true | |||
|
|
|||
| [features] | |||
There was a problem hiding this comment.
An example where both file order of tags and alphabetical order of tags fail.
Fix #740. The primary change is to limit the number of generated tags for each service to 5 by default. The limit can be configured in
autorust.toml. A[tags]section was added along with additional filtering options.