Skip to content

make reqwest optional for azure_core #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2022
Merged

make reqwest optional for azure_core #777

merged 4 commits into from
May 31, 2022

Conversation

ctaggart
Copy link
Contributor

For #735, it adds a check for cargo check -p azure_core --no-default-features which does not include enable_reqwest. Note, that these legacy errors can't be removed until #771.

rylev
rylev reviewed May 31, 2022
View reviewed changes
@cataggar cataggar added this to the core 0.3.0 milestone May 31, 2022
@cataggar cataggar added the Azure.Core The azure_core crate label May 31, 2022
@cataggar cataggar merged commit b12cb23 into Azure:main May 31, 2022
@ctaggart ctaggart deleted the no-reqwest branch May 31, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
Azure.Core The azure_core crate
Projects
None yet
Milestone
core 0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ctaggart @rylev @cataggar