use HttpClient in azure_identity #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 8, 2022
cataggar
previously approved these changes
Jun 8, 2022
| @@ -89,43 +107,54 @@ impl TokenCredential for ImdsManagedIdentityCredential { | |||
| _ => (), | |||
| } | |||
|
|
|||
| let msi_endpoint_url = Url::parse_with_params(&msi_endpoint, &query_items).context( | |||
| let url = Url::parse_with_params(&msi_endpoint, &query_items).context( | |||
There was a problem hiding this comment.
We may wish to switch to Url instead of http::Uri for its query parameters support.
|
I would appreciate a review of this. |
bmc-msft
reviewed
Jun 13, 2022
Comment on lines
-48
to
+53
| client: reqwest::Client, | ||
| http_client: &dyn HttpClient, |
There was a problem hiding this comment.
This feels weird from the consumer side, given the client we get from new_http_client is a Arc<dyn HttpClient>. In other areas in the API, we use .clone() instead of .as_ref(), which feels slightly more natural.
There was a problem hiding this comment.
Other than that, this LGTM and works in all of my use cases.
bmc-msft
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to move
reqwestout ofdependenciestodev-dependenciesinazure_identity.