Migrate storage_datalake to azure_core::error::Error
#795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
ctaggart
approved these changes
Jun 10, 2022
| @@ -54,8 +55,9 @@ impl TryFrom<&HeaderMap> for Properties { | |||
| fn try_from(headers: &HeaderMap) -> Result<Self, Self::Error> { | |||
| let header_value = headers | |||
| .get(PROPERTIES) | |||
There was a problem hiding this comment.
Hmm, may be we need to rename to .try_get and add a get that errors like this.
|
Looks good to me too. Thanks very much for working on this! |
johnbatty
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #771
Took a stab at migrating datalake - thought this might be dependent on #792, but seems to compile...