Skip to content

update datalake head and list operations - more blob migration #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 16, 2022

Conversation

roeap
Copy link
Contributor

@roeap roeap commented Jun 13, 2022

This PR Closes #786 and addresses an issue with the list operations in datalake crate.

Not sure if I went the right way and still need to add a test, but looking for some feedback :).

@roeap roeap changed the title Head datalake update datalake head and list operations Jun 13, 2022
}
}

mod i64_or_string {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In one of our programs we get a quoted value back for bot the is_directory and content_length fields. In that case serde fails to deserialize. But since encding numbers or bool as strings seems to not be done in other places in the API, i felt it was preferable to just have a custom deserialize that can handle both cases. IN any case we would want to do the conversion from sting... the added code complexity is hopefully bearable... then again there may be things I am overlooking :)

rylev
rylev previously requested changes Jun 15, 2022
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we can somewhat simplify the custom serialization but otherwise looks good.

@roeap
Copy link
Contributor Author

roeap commented Jun 16, 2022

@rylev - implemented your suggestions and fixed a required parameter in list_paths with some corresponding tests.

@ctaggart - this PR contains some fixed that would help us out a lot in delta-io/delta-rs#625, would it be possible to release a patch if this gets merged?

@roeap
Copy link
Contributor Author

roeap commented Jun 16, 2022

Very sorry for squeezing so much into this. I realized that all but one request in the blobs client had not yet been updated to the new errors - so i did that work here. Hoping that's what was intended :)

If this is too much for one PR, I can split that off - all "non-mechanical" changes should be contained in the datalake crate.

@roeap roeap changed the title update datalake head and list operations update datalake head and list operations - more blob migration Jun 16, 2022
cataggar
cataggar previously approved these changes Jun 16, 2022
@cataggar
Copy link
Member

this PR contains some fixed that would help us out a lot in delta-io/delta-rs#625, would it be possible to release a patch if this gets merged?

@roeap , please bump the version. This contains more than what normally goes in a patch. May be 0.4.0 instead of 0.3.1.

@roeap
Copy link
Contributor Author

roeap commented Jun 16, 2022

Thanks @cataggar! - bumped storage_blobs and storage_datalake to 0.4.0

@cataggar cataggar dismissed their stale review June 16, 2022 15:17

I requested a few changes.

@roeap
Copy link
Contributor Author

roeap commented Jun 16, 2022

added some tests and implemented changes.

@cataggar cataggar dismissed rylev’s stale review June 16, 2022 15:35

Requested changes were made.

@cataggar cataggar merged commit c5e1af2 into Azure:main Jun 16, 2022
@roeap roeap deleted the head-datalake branch June 16, 2022 21:14
@cataggar
Copy link
Member

@roeap, they are published. #820

@roeap
Copy link
Contributor Author

roeap commented Jun 17, 2022

Thanks @cataggar, @bmc-msft for making this happen so quickly!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[datalake] Expose Content-Length in get_properties
4 participants