-
Notifications
You must be signed in to change notification settings - Fork 290
update datalake head and list operations - more blob migration #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
} | ||
|
||
mod i64_or_string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In one of our programs we get a quoted value back for bot the is_directory
and content_length
fields. In that case serde fails to deserialize. But since encding numbers or bool as strings seems to not be done in other places in the API, i felt it was preferable to just have a custom deserialize that can handle both cases. IN any case we would want to do the conversion from sting... the added code complexity is hopefully bearable... then again there may be things I am overlooking :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we can somewhat simplify the custom serialization but otherwise looks good.
@rylev - implemented your suggestions and fixed a required parameter in @ctaggart - this PR contains some fixed that would help us out a lot in delta-io/delta-rs#625, would it be possible to release a patch if this gets merged? |
Very sorry for squeezing so much into this. I realized that all but one request in the blobs client had not yet been updated to the new errors - so i did that work here. Hoping that's what was intended :) If this is too much for one PR, I can split that off - all "non-mechanical" changes should be contained in the datalake crate. |
@roeap , please bump the version. This contains more than what normally goes in a patch. May be 0.4.0 instead of 0.3.1. |
Thanks @cataggar! - bumped storage_blobs and storage_datalake to |
added some tests and implemented changes. |
This PR Closes #786 and addresses an issue with the list operations in datalake crate.
Not sure if I went the right way and still need to add a test, but looking for some feedback :).