move storage queues to pipeline architecture #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jun 27, 2022
Comment on lines
+67
to
+68
| /// Deletes the message. The message must not have been made visible again | ||
| /// or this call would fail. |
There was a problem hiding this comment.
Suggested change
| /// Deletes the message. The message must not have been made visible again | |
| /// or this call would fail. | |
| /// Deletes the message. | |
| /// | |
| /// The message must not have been made visible again or this call would fail. |
Comment on lines
+73
to
+74
| /// Updates the message. The message must not have been made visible again | ||
| /// or this call would fail. |
There was a problem hiding this comment.
Suggested change
| /// Updates the message. The message must not have been made visible again | |
| /// or this call would fail. | |
| /// Updates the message. | |
| /// | |
| /// The message must not have been made visible again or this call would fail. |
Also, it might be nice to place this above delete. In Cosmos, we generally follow the order: get, create, update, delete for ordering operations.
Comment on lines
115
to
116
| /// Puts a message in the queue. The body will be passed | ||
| /// to the `execute` function of the returned struct. |
There was a problem hiding this comment.
Suggested change
| /// Puts a message in the queue. The body will be passed | |
| /// to the `execute` function of the returned struct. | |
| /// Puts a message in the queue. | |
| /// | |
| /// The body will be passed to the `execute` function of the returned struct. |
| queue_client, | ||
| number_of_messages: None, | ||
| visibility_timeout: None, | ||
|
|
| } | ||
|
|
||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| struct MessageInternal { |
There was a problem hiding this comment.
FWIW: we probably could easily just implement Deserialize directly on Message
|
|
||
| let a: azure_core::Result<Vec<QueueStoredAccessPolicy>> = | ||
| StoredAccessPolicyList::from_xml(&body) | ||
| .map_kind(ErrorKind::DataConversion)? |
There was a problem hiding this comment.
I think for these errors we really should put more context. If this bubbles to the user, they'll only get some cryptic xml parsing error.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.