Skip to content

Only add params if they don't already exist #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jun 29, 2022

Fixes #867

Once we move all of the SDKs that use the StorageAccountClient to the pipeline architecture, this workaround can be removed.

@rylev rylev requested a review from bmc-msft June 29, 2022 16:49
Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole if block could probably move to match &self.storage_credentials which happens a few lines later.

@rylev
Copy link
Contributor Author

rylev commented Jun 29, 2022

@bmc-msft that match expression will be deleted when we move all the Storage SDKs to the pipeline architecture since this is all handled by the authentication policy.

@rylev rylev merged commit 4a8841f into Azure:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SASToken auth broken
2 participants