Skip to content

use StatusCode rather than u16 in HttpError #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Jul 1, 2022

As we're exposing the StatusCode enum, this makes the consumption of the
errors significantly easier to deal with.

Resolves #870

As we're exposing the StatusCode enum, this makes the consumption of the
errors significantly easier to deal with.
@bmc-msft bmc-msft changed the title use StatusCode rather than u16 use StatusCode rather than u16 in HttpError Jul 1, 2022
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see we don't have any examples that are impacted by this change. Would you mind adding an issue for creating such an example or test?

@bmc-msft bmc-msft merged commit 3622bd5 into Azure:main Jul 1, 2022
@bmc-msft bmc-msft deleted the use-status-code-directly branch July 1, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider using StatusCode instead of u16 in HttpError
4 participants