Skip to content

House cleaning for blob clients #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jul 4, 2022

A bit of house cleaning:

  • Add docs to BlobClient operation methods
  • Rearrange the methods so that they are in some order (generally: first general get, crate, update, and delete operations and then operations specific to certain types of blobs)
  • Move methods in other clients around so public ones are on top
  • Rename update_page to put_page to mirror other "put" operations and the docs.

@rylev rylev requested a review from bmc-msft July 4, 2022 12:36
@rylev rylev force-pushed the minimum-blob-client-docs branch from 71ec2ee to 4eb31cb Compare July 4, 2022 12:43
@@ -234,18 +272,6 @@ impl BlobClient {
) -> azure_core::Result<Response> {
self.container_client.send(context, request).await
}

pub async fn exists(&self) -> azure_core::Result<bool> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rylev rylev force-pushed the minimum-blob-client-docs branch from 4eb31cb to 6842e8e Compare July 11, 2022 10:31
@rylev rylev merged commit 1900e31 into Azure:main Jul 11, 2022
@rylev rylev deleted the minimum-blob-client-docs branch July 11, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants