Skip to content

lowercase x-identity-header used in IMDS #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Jul 6, 2022

No description provided.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I'm concerned why this is necessary. HTTP headers should be read case-insensitively. Is the service not doing so?

@cataggar
Copy link
Member

cataggar commented Jul 6, 2022

This is inserting a header. The reason to standardize on lowercase is in #872 (comment).

@cataggar cataggar merged commit 70f0706 into Azure:main Jul 6, 2022
@bmc-msft bmc-msft deleted the fix-another-lowercase-header branch July 6, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants