Application initializer does not make tenant discovery calls #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Jun 9, 2020
rayluo
reviewed
Jun 12, 2020
rayluo
reviewed
Jun 15, 2020
rayluo
reviewed
Jun 15, 2020
rayluo
reviewed
Jun 16, 2020
rayluo
reviewed
Jun 16, 2020
rayluo
reviewed
Jun 17, 2020
rayluo
reviewed
Jun 17, 2020
rayluo
reviewed
Jun 17, 2020
There was a problem hiding this comment.
The current modification looks clean. Good job!
For such a change that would impact literally every existing MSAL feature, have we tested all the scenarios, especially those not currently automated? I would suggest we scan through every MSAL public api, and run a test invoking that api. And then you can reply back with a summary of your test coverage.
|
Tested the public api and added a few more changes |
rayluo
reviewed
Jun 18, 2020
rayluo
reviewed
Jun 18, 2020
|
@rayluo summarized our offline conversation in the comment to give a context on the changes made! |
rayluo
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: This will fix #187