Skip to content

Fix FormatException cause by empty json file #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix FormatException cause by empty json file #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf8d424
test: add test for empty file
bothyculture May 4, 2025
ae0fc03
fix: check file is not empty
bothyculture May 4, 2025
563801d
test: move test
bothyculture May 4, 2025
9a99dec
test: check whether onError is called
bothyculture May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ter_cache_manager/lib/src/storage/cache_info_repositories/json_cache_info_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class JsonCacheInfoRepository extends CacheInfoRepository
Future<void> _readFile(File file) async {
_cacheObjects.clear();
_jsonCache.clear();
if (await file.exists()) {
if (await file.exists() && await file.length() > 0) {
try {
final jsonString = await file.readAsString();
final json = jsonDecode(jsonString) as List<dynamic>;
Expand Down
20 changes: 20 additions & 0 deletions flutter_cache_manager/test/repositories/json_file_repository_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:io';

import 'package:collection/collection.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_cache_manager/src/storage/cache_info_repositories/json_cache_info_repository.dart';
import 'package:flutter_cache_manager/src/storage/cache_object.dart';
import 'package:flutter_test/flutter_test.dart';
Expand Down Expand Up @@ -41,6 +42,25 @@ void main() {
await repository.open();
});

test('Open repository should not report error when file is empty',
() async {
var originalOnError = FlutterError.onError;
FlutterError.onError = (FlutterErrorDetails details) {
throw details.exception;
};

final tempFile = File('${Directory.systemTemp.path}/test_empty.json');
await tempFile.create();
expect(await tempFile.length(), 0);

final repository = JsonCacheInfoRepository.withFile(tempFile);
await repository.open();

expect(await repository.getAllObjects(), isEmpty);
await tempFile.delete();
FlutterError.onError = originalOnError;
});

test('An open repository can be closed', () async {
var repository = await JsonRepoHelpers.createRepository();
var isClosed = await repository.close();
Expand Down