feat: store and restore ecdsa dkg sessions #6368
Merged
+277
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadalfaiyazbitgo
requested review from
pranavjain97,
rahulhegde-bitgo,
Copilot,
zahin-mohammad and
islamaminBitGo
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to store and restore ECDSA DKG sessions, enabling session state to be saved and later recovered during the multi-round DKG protocol.
- Introduces new methods getSessionData() and restoreSession() in the DKG class.
- Updates unit tests to verify that a DKG session can be resumed from stored session data.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/sdk-lib-mpc/test/unit/tss/ecdsa/dklsDkg.ts | Adds an extensive test to simulate and verify session restoration across DKG rounds. |
| modules/sdk-lib-mpc/src/tss/ecdsa-dkls/dkg.ts | Implements session serialization (getSessionData) and restoration (restoreSession) functionality. |
Comments suppressed due to low confidence (1)
modules/sdk-lib-mpc/src/tss/ecdsa-dkls/dkg.ts:292
- Adding inline comments to explain the purpose and expected format of each field in DkgSessionData could improve code clarity for future maintainers.
getSessionData(): DkgSessionData {
| @@ -282,4 +282,210 @@ describe('DKLS Dkg 2x3', function () { | |||
| assert.deepEqual(DklsTypes.getCommonKeychain(userKeyShare), DklsTypes.getCommonKeychain(bitgoKeyShare)); | |||
| assert.deepEqual(DklsTypes.getCommonKeychain(backupKeyShare), DklsTypes.getCommonKeychain(bitgoKeyShare)); | |||
| }); | |||
|
|
|||
| it('should successfully finish DKG using restored sessions', async function () { | |||
There was a problem hiding this comment.
[nitpick] This test block is very long and complex; consider splitting it into smaller, focused tests to improve maintainability and ease debugging.
Copilot uses AI. Check for mistakes.
islamaminBitGo
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5188
TICKET: WP-5188