Skip to content

Add ipython 9 compat #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Add ipython 9 compat #290

merged 3 commits into from
Apr 2, 2025

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Mar 5, 2025

This class was removed in IPython 9. Reported as blink1073/oct2py#337

@blink1073
Copy link
Contributor Author

@dsblank I no longer have merge access, since I pared down my open source involvement last fall.

@dsblank
Copy link
Member

dsblank commented Mar 26, 2025

@blink1073 ok, thanks for the update. I'm swamped at work. Who would be a good candidate to take over for us?

@blink1073
Copy link
Contributor Author

@ellert would you be interested in maintaining this repo?

@guitargeek
Copy link

Hi @blink1073, what is your recommendation for a project that relies on this fix in metakernel, like the ROOT C++ kernel?

https://github.com/root-project/root/blob/master/bindings/jupyroot/python/JupyROOT/kernel/rootkernel.py#L41

@blink1073
Copy link
Contributor Author

The only option available is to pin ipython<9 in your dependencies, as far as I know.

@blink1073
Copy link
Contributor Author

@dsblank if you can add me back as a collaborator with admin access I can merge and release this fix.

@dsblank
Copy link
Member

dsblank commented Apr 1, 2025

Ok, will do that shortly. Thanks!

@dsblank
Copy link
Member

dsblank commented Apr 2, 2025

Invite sent.

@blink1073 blink1073 merged commit 864d7a2 into Calysto:main Apr 2, 2025
16 of 17 checks passed
@blink1073
Copy link
Contributor Author

I finished the release.

@blink1073 blink1073 deleted the ipython-9-compat branch April 2, 2025 14:10
@dsblank
Copy link
Member

dsblank commented Apr 3, 2025

Thank you @blink1073 ! We'll have to work on finding some maintainers to take over some projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants