Skip to content

Add distanceDisplayCondition to ModelExperimental #10481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2022

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Jun 24, 2022

This PR adds distanceDisplayCondition to ModelExperimental. Pretty straightforward, just mimics the implementation in Model.js. Here's the Sandcastle for testing.

I ended up reorganizing the documentation for the constructor / fromGltf function, but it was to match the order of the parameters in Model. This way it's easier to see the differences between the APIs.

@j9liu j9liu requested a review from ptrgags June 24, 2022 20:09
@cesium-concierge
Copy link

Thanks for the pull request @j9liu!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@ptrgags ptrgags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j9liu looks good! I had one small suggestion about variable naming before I merge this.

@j9liu
Copy link
Contributor Author

j9liu commented Jun 27, 2022

@ptrgags updated!

@ptrgags
Copy link
Contributor

ptrgags commented Jun 27, 2022

Looks good, thanks @j9liu!

@ptrgags ptrgags merged commit cfa3042 into main Jun 27, 2022
@ptrgags ptrgags deleted the model-experimental-distance-display-condition branch June 27, 2022 20:55
@j9liu j9liu mentioned this pull request Jun 28, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants