Skip to content

Add support for CustomShader in a model entity #10747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Sep 1, 2022

I noticed this morning that ModelVisualizer was not propagating the customShader field to the created Model.

This PR adds a property customShader that lets you pass in a CustomShader instance to the entities.

Example Sandcastle -- applies a custom shader that takes the diffuse color and cycles the color channels RGB -> GBR

image

@lilleyse could you review?

@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ptrgags ptrgags requested a review from lilleyse September 1, 2022 13:44
@lilleyse lilleyse merged commit 6cc5439 into main Sep 1, 2022
@lilleyse lilleyse deleted the custom-shaders-entities branch September 1, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants