Reorganize how normalized instance attributes are handled #10771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10766
As of the latest
main
, instance feature IDs weren't working because they were incorrectly being dequantized inGltVertexBufferLoader
.As described in #10766 (comment), we thought it would be better to not dequantize in the loader at all, only dequantize when absolutely necessary. It turns out there's only one such case where we need to dequantize on the CPU:
ROTATION
attributes withnormalize: true
. Translations and scales are not quantized according to the table in theEXT_mesh_gpu_instancing
spec.To summarize, this PR:
GltfVertexBufferLoader
andGltfLoader
InstancingPipelineStage
EDIT: Whoops forgot to add Sandcastle links: