Skip to content

Fix models that have mix of draco and non-draco attributes #10936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2022

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Dec 3, 2022

Before After
broken fixed

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor

ggetz commented Dec 6, 2022

@sanjeetsuhag Can you please review?

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good. @lilleyse Is this a regression from the Model.js implementation? If so, should we call out a fix in CHANGES.md?

@lilleyse
Copy link
Contributor Author

lilleyse commented Dec 7, 2022

@sanjeetsuhag I'm not sure if the old Model.js had this problem, but I updated CHANGES.md anyways

@sanjeetsuhag
Copy link
Contributor

Thanks @lilleyse!

@sanjeetsuhag sanjeetsuhag merged commit 646cc00 into main Dec 7, 2022
@sanjeetsuhag sanjeetsuhag deleted the fix-draco-mixed-attributes branch December 7, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants