Skip to content

Fix geocode typo in Clipping Regions sandcastle #12352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Dec 2, 2024

Description

The Clipping regions sandcaslte was referencing an undefined variable because of a typo.

Issue number and link

Related to #12299

Testing plan

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Copy link

github-actions bot commented Dec 2, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I confirmed that the Sandcastle now works for me.
Thanks @jjspace!

@jjhembd jjhembd added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit dbe0c0a Dec 2, 2024
10 checks passed
@jjhembd jjhembd deleted the update-geocoder-sandcastle branch December 2, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants