-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Replaced defaultValue with ?? #12507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for the pull request, @jfayot! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @jfayot! Overall the code changes all seem good to me, just a couple minor comments.
Would you also be able to post a comment with the steps/process you took to do this? I suspect that anyone that was using these functions (like some of our other internal libraries) is using them everywhere and need a large PR like this. It would greatly benefit them if you already found a process that works well
packages/widgets/Source/BaseLayerPicker/BaseLayerPickerViewModel.js
Outdated
Show resolved
Hide resolved
Hi @jjspace ! Will you have some time to dedicate on reviewing final changes for this PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and comments @jfayot. This is very close, just some last organizational comments
@jjspace this should be ready for another review! The migration scripts have been updated accordingly... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really happy to get this in! Thanks for all the work on this @jfayot!
Description
defaultValue
function, replaced by nullish coalescing operator.defaultValue.EMPTY_OBJECT
, replaced byFrozen.EMPTY_OBJECT
.Frozen
namespace withEMPTY_ARRAY
andEMPTY_OBJECT
frozen values and associated documentation.[]
byDefaultValues.EMPTY_ARRAY
only where appropriate.Issue number and link
Fixes #11674
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change