Windows mingw #137
Merged
Windows mingw #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filimonov
force-pushed
the
windows-mingw
branch
3 times, most recently
from
8c7593b to
52f3fae
Compare
filimonov
force-pushed
the
windows-mingw
branch
4 times, most recently
from
402b0dd to
21e1014
Compare
|
ColumnsCase.Date2038 on i686 - real issue? P.S. I don't care too much, we can also comment out i686 with comment for now. |
Enmk
reviewed
Feb 1, 2022
.github/workflows/windows_mingw.yml
Outdated
| matrix: | ||
| include: | ||
| - { sys: mingw64, env: x86_64 } | ||
| - { sys: mingw32, env: i686 } |
There was a problem hiding this comment.
Isn't i686 obsolete and long forgotten arch of the Pentium-IV era? IMO, we shouldn't waste resources building\testing against that, unless there is a really strong reason.
There was a problem hiding this comment.
ok for me. Just tried the whole matrix available in mingw
filimonov
force-pushed
the
windows-mingw
branch
from
21e1014 to
ff40ea4
Compare
It is too old to be practically useful
This was referenced Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.